Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(load-test): Use AWS s3 for tekton results in dev mode #1211

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(load-test): Use AWS s3 for tekton results in dev mode #1211

wants to merge 1 commit into from
+415 −96

Conversation

pmacik
Copy link
Collaborator

@pmacik pmacik commented Jun 6, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 6, 2024

Hi @pmacik. Thanks for your PR.

I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pmacik pmacik force-pushed the tekton-results-s3 branch from a53c19a to 64a9fc9 Compare June 6, 2024 10:47
@pmacik pmacik changed the title Tekton results s3 feat(load-test): Use AWS s3 for tekton results in dev mode Jun 6, 2024
@pmacik pmacik force-pushed the tekton-results-s3 branch 5 times, most recently from 2ef2035 to a739659 Compare June 12, 2024 06:56
@pmacik pmacik force-pushed the tekton-results-s3 branch from a739659 to db43afe Compare June 20, 2024 10:13
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jhutar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmacik pmacik force-pushed the tekton-results-s3 branch from db43afe to 881055c Compare June 21, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
15-30 min do-not-merge/work-in-progress needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmacik @openshift-merge-robot